refactor config.parse_config

* add debug-output
* return config-values as expected by __main__.main
* remove test_config_invalid
* fix tests

tsstats/config.py

@@ -1,19 +1,26 @@
-from os.path import abspath
-
-from tsstats.exceptions import InvalidConfig
-
 try:
     from configparser import ConfigParser
 except ImportError:
     from ConfigParser import ConfigParser
 
+import logging
+
+logger = logging.getLogger('tsstats')
+
 
 def parse_config(config_path):
+    logger.debug('reading config')
     config = ConfigParser()
     config.read(config_path)
-    if not config.has_section('General') or not \
+    # use dict(ConfigParser.items) to get an easy-to-use interface
-        (config.has_option('General', 'log') and
+    # compatible with py2 and py3
-         config.has_option('General', 'output')):
+    config_items = dict(config.items('General'))
-        raise InvalidConfig
+    if 'debug' in config_items:
-    return (abspath(config.get('General', 'log')),
+        config_items['debug'] = config.getboolean('General', 'debug')
-            abspath(config.get('General', 'output')))
+    logger.debug('raw config: %s', config_items)
+    return (
+        config_items.get('idmap'),
+        config_items.get('log'),
+        config_items.get('output'),
+        config_items.get('debug', False)
+    )

tsstats/tests/test_config.py

@@ -8,7 +8,6 @@ from os.path import abspath, exists
 
 import pytest
 
-from tsstats import exceptions
 from tsstats.config import parse_config
 
 configpath = abspath('tsstats/tests/res/test.cfg')
@@ -31,20 +30,15 @@ def config(request):
     request.addfinalizer(clean)
 
 
-def test_invalid_config(config):
-    create_config({
-        'loggfile': 'tsstats/tests/res/test.log',
-        'outputfile': ''
-    })
-    with pytest.raises(exceptions.InvalidConfig):
-        _, _, _, _ = parse_config(configpath)
-
-
 def test_config(config):
     create_config({
+        'idmap': 'tsstats/tests/res/id_map.json',
         'log': 'tsstats/tests/res/test.log',
         'output': 'output.html',
+        'debug': 'true'
     })
-    log, output = parse_config(configpath)
+    idmap, log, output, debug = parse_config(configpath)
-    assert log == abspath('tsstats/tests/res/test.log')
+    assert idmap == 'tsstats/tests/res/id_map.json'
-    assert output == abspath('output.html')
+    assert log == 'tsstats/tests/res/test.log'
+    assert output == 'output.html'
+    assert debug is True